Eks integ tests #77
Merged
Eks integ tests #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Jan 12, 2023
| @@ -123,9 +123,6 @@ jobs: | |||
| - # issue #49 | |||
| app_to_test: ts-eks-helm | |||
| mode: upgrade | |||
There was a problem hiding this comment.
I assume this one is still broken because of #48? (If so, let's update line 123 just for completeness)
There was a problem hiding this comment.
well its broken because our current release branch is broken mainly. So we need 2 releases then can enable this and the helm one.
Comment on lines
+37
to
+38
| lb = new aws.lb.LoadBalancer(`${appName}-${resourceId}-alb`, { | ||
| name: `${appName}-${resourceId}`, |
There was a problem hiding this comment.
Will this (and similar) conflict with @DavidSeptimus-Klotho's work? If so, probably just need to coordinate.
There was a problem hiding this comment.
i mentioned i was doing this to him, he said he hadnt touched these modules yet so should be good
|
atorres-klo
pushed a commit
that referenced
this pull request
Aug 14, 2024
Only change properties when it's coming from solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Does any part of it require special attention?
• Does it relate to or fix any issue? closes #69 and closes #76
Did some naming fixes to prevent running into conflicts in our test. None of the naming fixes are external resources so it is backwards compatible, the user shouldnt even notice outside of pulumi preview.
Had to modify our kubeconfig logic due to the pulumi bug
adding just the fresh tests back. Upgrade will fail due to the released version having this bug so we can add those back in 2 releases.
Standard checks